Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the ordering of the ring and the degree in matrix_group? #2098

Closed
fingolfin opened this issue Mar 21, 2023 · 0 comments · Fixed by #2587
Closed

Change the ordering of the ring and the degree in matrix_group? #2098

fingolfin opened this issue Mar 21, 2023 · 0 comments · Fixed by #2587

Comments

@fingolfin
Copy link
Member

fingolfin commented Mar 21, 2023 •
edited

Could we change the ordering of the ring and the degree, so matrix_group(::Ring, ::Int, ::T...) to align this with matrix, matrix_algebra and matrix_space? (I appreciate that this might be a bigger change, I just wanted to ask for opinions.)

Originally posted by @joschmitt in #2025 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reorder input arguments of matrix_group joschmitt/Oscar.jl
1 participant
@fingolfin