You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Two problems with the docstring for binomial_primary_decomposition:
It references ζ (zeta), but the code example was changed to use z
In the example z actually turns up with two different meanings: once it is a variable in a polynomial ring; and once for a root of unity z(3). I believe that z comes from the QQAb code.
Since z is used a lot in polynomial rings, it seems best if in the printing of roots of unity it is changed to something else, e.g. zeta (spelled out) -- in unicode printing mode it can of course stay as ζ
Secondly, the binomial_primary_decomposition docstring should be adjusted to use that new symbol used for QQAb printing (it could also point to Oscar.with_unicode I guess)
The text was updated successfully, but these errors were encountered:
Two problems with the docstring for
binomial_primary_decomposition
:z
z
actually turns up with two different meanings: once it is a variable in a polynomial ring; and once for a root of unityz(3)
. I believe thatz
comes from theQQAb
code.Since
z
is used a lot in polynomial rings, it seems best if in the printing of roots of unity it is changed to something else, e.g.zeta
(spelled out) -- in unicode printing mode it can of course stay as ζSecondly, the
binomial_primary_decomposition
docstring should be adjusted to use that new symbol used forQQAb
printing (it could also point toOscar.with_unicode
I guess)The text was updated successfully, but these errors were encountered: