Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few number theory commands in Oscar #674

Closed
Asconik opened this issue Sep 10, 2021 · 1 comment · Fixed by thofma/Hecke.jl#1122
Closed

A few number theory commands in Oscar #674

Asconik opened this issue Sep 10, 2021 · 1 comment · Fixed by thofma/Hecke.jl#1122
Labels
documentation Improvements or additions to documentation topic: number theory

Comments

@Asconik
Copy link

Asconik commented Sep 10, 2021

  1. The ramified_primes command does not work on its own, only by entering Hecke.ramified_primes:
    https://oscar-system.github.io/Oscar.jl/stable/Hecke/orders/orders/#ramified_primes-Tuple{NfOrd}

  2. Same issue for isprincipal_fac_elem, gotta enter Hecke.isprincipal_fac_elem:
    https://oscar-system.github.io/Oscar.jl/stable/Hecke/orders/ideals/#isprincipal_fac_elem-Tuple{NfOrdIdl}

  3. The documentation for the Order method
    https://oscar-system.github.io/Oscar.jl/stable/Hecke/orders/orders/#Order-Tuple{AnticNumberField,%20Vector{nf_elem}}
    is incorrect:

  • It needs the number field as first argument before all the rest
  • The command includes the keyword "cached", but the description says "isbasis" (but "isbasis" is also a keyword? Are there actually three keywords in all?)
  1. In the following ideal method
    https://oscar-system.github.io/Oscar.jl/stable/Hecke/orders/ideals/#ideal-Tuple{NfOrd,%20fmpz_mat}
    why are "check" and "x_in_hnf" not keywords? Like in the Order method in 3)
@thofma
Copy link
Collaborator

thofma commented Sep 10, 2021

Thanks for the report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation topic: number theory
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants