Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JuliaExperimental fails to load when Nemo not present #65

Closed
sebasguts opened this issue Oct 10, 2018 · 1 comment
Closed

JuliaExperimental fails to load when Nemo not present #65

sebasguts opened this issue Oct 10, 2018 · 1 comment
Assignees

Comments

@sebasguts
Copy link
Contributor

Currently, there is a using Nemo in utils.jl, which produced an Error if JuliaExperimental is loaded when using a Julia without Nemo.

Maybe we should split up the utils.jl file and load the Nemo specific functions only if Nemo can also be imported into GAP?

ThomasBreuer added a commit to ThomasBreuer/GAP.jl that referenced this issue Oct 15, 2018
when we load JuliaExperimental.
(Of course most code of the package will not be available
if no Julia packages are available.)
For that, `gap/utils.gi` and `julia/utils.jl` have been split
into a Nemo independent part and a part which requires Nemo.
(This addresses issue oscar-system#65.)

The same holds for the test files,
we cannot expect that all tests can be run with a given installation
of Julia.
Therefore, `TestDirectory` has to be run just on those test files
for which the necessary Julia packages are available.

Besides the general test mechanism,
also some tests have now been adjusted to Julia 1.0.
@ThomasBreuer
Copy link
Member

This problem has been solved with pull request #77 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants