Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A-Frame 0.2.0 breaks stereo-component #1

Closed
atomicguy opened this issue Mar 17, 2016 · 5 comments
Closed

A-Frame 0.2.0 breaks stereo-component #1

atomicguy opened this issue Mar 17, 2016 · 5 comments

Comments

@atomicguy
Copy link
Contributor

The updated component handling in A-Frame 0.2.0 breaks aframe-stereo-component.

Specifically the addBehavior step in update appears to be a problem.

I've been sandboxing in a codepen, but still don't have it working again.

@oscarmarinmiro
Copy link
Collaborator

Thanks!

Just arrived at a keyboard :)

I've just changed the release description in https://github.com/oscarmarinmiro/aframe-stereo-component/releases/tag/v0.1.1, to make clear it's compatible with https://github.com/aframevr/aframe/releases/tag/v0.1.2

Checking your PR's and the 'tick' issue in order to make a https://github.com/aframevr/aframe/releases/tag/v0.2.0-rc1 compatible version

Are you on Twitter?

@atomicguy
Copy link
Contributor Author

Cool :)

Yup, @AtomSchuster on Twitter

-adam..

On Mar 20, 2016, 2:04 PM -0400, oscarmarinmironotifications@github.com, wrote:

Thanks!

Just arrived at a keyboard :)

I've just changed the release description inhttps://github.com/oscarmarinmiro/aframe-stereo-component/releases/tag/v0.1.1, to make clear it's compatible withhttps://github.com/aframevr/aframe/releases/tag/v0.1.2

Checking your PR's and the 'tick' issue in order to make ahttps://github.com/aframevr/aframe/releases/tag/v0.2.0-rc1compatible version

Are you on Twitter?


You are receiving this because you authored the thread.
Reply to this email directly orview it on GitHub(#1 (comment))

@oscarmarinmiro
Copy link
Collaborator

Hey Adam, working on it, the tick thing was done, now what happens is that new aframe is using BufferSphereGeometry instead of SphereGeometry, so changing the UV's is different..

Also every object is a group so had to update the code to access object3D.

I'm onto it, with a bit of luck tomorrow can be commited :)

@atomicguy
Copy link
Contributor Author

I had a suspicion that the solution might be more involved than I expected...

I actually plan to use stereo image pairs, so I didn't dig as much into the spherical video parts of the code.

@oscarmarinmiro
Copy link
Collaborator

Now it's done, your code incorporated :)

I'll tweet it tomorrow, if you see any issues just tell...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants