Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some Embeds Fail with JsonLdException #356

Closed
bobdercole opened this issue May 20, 2020 · 4 comments
Closed

Some Embeds Fail with JsonLdException #356

bobdercole opened this issue May 20, 2020 · 4 comments

Comments

@bobdercole
Copy link
Contributor

Hi,

I noticed that some embeds, that were previously working, are now failing with an uncaught exception.

For example https://vimeo.com/ results in this:

(ML\JsonLD\Exception\JsonLdException(code: loading remote context failed): Loading http://schema.org failed at /application/vendor/ml/json-ld/Processor.php:1752)
(ML\JsonLD\Exception\JsonLdException(code: loading document failed): Invalid media type (near "text/html") at /application/vendor/ml/json-ld/FileGetContentsLoader.php:105)

The demo shows the same issue:

image
@oscarotero
Copy link
Owner

Ok, I'll take a look. Thanks for let me know.

@oscarotero
Copy link
Owner

I just commited a fix for this. Could you please test it before tag a new version?
Thanks

@bobdercole
Copy link
Contributor Author

That seems to work. Thank you!

@oscarotero
Copy link
Owner

Version 4.2.0 released including this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oscarotero @bobdercole