add fix to skip ' with trailing slash #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What if we have an even number of |
|
I don`t check that issue with multiple \ but without that fix ill get
instead
in my translations |
oscarotero
requested changes
Jul 26, 2017
There was a problem hiding this comment.
Thanks for the contribution. It looks fine but in my opinion, there's a better way to handle this:
Capture the first \ character, move one position and save the next character. This fixes all possible cases (like \\ or \'\\, etc). It should be applied for double quotes too.
|
Yes you definitely right, your solution i better. |
…n.__('You don\'t have any bookmark.')}
|
Should work now
|
|
Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add fix to skip ' with trailing slash in translation for example {i18n.__('You don't have any bookmark.')}