Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend .gitattributes file #168

Merged
merged 2 commits into from Mar 7, 2018
Merged

Extend .gitattributes file #168

merged 2 commits into from Mar 7, 2018

Conversation

swissspidy
Copy link
Contributor

There's no need for CHANGELOG.md, CONTRIBUTING.md and phpcs.xml to be part of the package when installing the library via Composer.

@oscarotero
Copy link
Member

I disagree.
CHANGELOG.md should be provided to any developer and consumer of any sofware. see this
CONTRIBUTING.md is not so important but is nice to have.
phpcs.xml can be ignored.

@swissspidy
Copy link
Contributor Author

@oscarotero Fair enough. I now only added phpcs.xml to the list.

@oscarotero oscarotero merged commit 9ba1532 into php-gettext:master Mar 7, 2018
@oscarotero
Copy link
Member

Thanks!

@swissspidy swissspidy deleted the gitattributes branch March 7, 2018 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants