Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Translations return type hinting #175

Merged
merged 1 commit into from Mar 27, 2018

Conversation

ArthurHoaro
Copy link
Contributor

@ArthurHoaro ArthurHoaro commented Mar 27, 2018

Without return types in @method instructions, I have to manually add @var Translations $foo to have PHPStorm autocompletion (also :D).

(EDIT: also the tests are failing since your last merge)

@oscarotero oscarotero merged commit e8b9fdf into php-gettext:master Mar 27, 2018
@oscarotero
Copy link
Member

thanks!

@ArthurHoaro ArthurHoaro deleted the return-type-hinting branch March 28, 2018 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants