Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test enhancement #177

Merged
merged 2 commits into from May 16, 2018
Merged

Test enhancement #177

merged 2 commits into from May 16, 2018

Conversation

peter279k
Copy link
Contributor

@peter279k peter279k commented Apr 24, 2018 •
edited

Changed log

  • Set the higher PHPUnit version for the php-7.2.
  • Use the expectedException annotation to compatible the different PHPUnit version.
  • Let testPluralFromValidation test method have the assertInstanceOf assertion and avoid the risky test that don't perform any assertions.

@oscarotero oscarotero merged commit f1b2a7f into php-gettext:master May 16, 2018
@oscarotero
Copy link
Member

Thanks!

icebird93 pushed a commit to icebird93/Gettext that referenced this pull request Jun 18, 2018
@peter279k @icebird93
Test enhancement (php-gettext#177)
07bb662 
* Test enhancement

* Fix the assert expected class for php-5.4 test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peter279k @oscarotero