Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VueJS DOM parsing fix #188

Merged
merged 1 commit into from
Aug 27, 2018
Merged

VueJS DOM parsing fix #188

merged 1 commit into from
Aug 27, 2018

Conversation

briedis
Copy link
Contributor

@briedis briedis commented Aug 27, 2018

When using $domScript->textContent, DOM library starts parsing some tags within strings and messes the output up. For example alert("<span>text</span>"); becomes alert("<span>text");
So instead of DOM operations, we extract script contents with a regex.

@oscarotero oscarotero merged commit cb08ec5 into php-gettext:master Aug 27, 2018
@oscarotero
Copy link
Member

Fair enought

@briedis
Copy link
Contributor Author

briedis commented Aug 27, 2018

Can we get a minor release, pretty please? :)

@briedis briedis deleted the vuejs-script-parsing branch August 27, 2018 11:19
@oscarotero
Copy link
Member

new version available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants