Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple domain scan #223

Merged
merged 9 commits into from Sep 15, 2019
Merged

Multiple domain scan #223

merged 9 commits into from Sep 15, 2019

Conversation

briedis
Copy link
Contributor

@briedis briedis commented Sep 9, 2019

We use this library in a pretty big project which has hundreds (probably more than a thousand) files we need to scan. To scan the whole source we need 15+ minutes which is a lot, especially if the code changes very rapidly.

The main issue is that to scan each domain, the library has to parse a file for each domain separately. So my solution offers the option to scan a single file only once for all the domains in a single go.

I benchmarked my solution when you need to scan 20 domains against the old way where you scan each domain individually and the difference was 12x. And that was for a simple PHP file with <50 lines. The speed gain should be even larger for JS files which need complex parsing, a lot of string operations.

I tried to implement this as an additional feature so there would be no backward compatibility issues. Currently it supports PHP/JS(VueJS) parsing.

Some minor refactoring is included too.

@briedis
Copy link
Contributor Author

briedis commented Sep 9, 2019

Specified trusty distribution in the Travis.yml file, because 5.4 and 5.5 was not building.
See: https://travis-ci.community/t/php-5-4-and-5-5-archives-missing/3723/4

@oscarotero
Copy link
Member

Thanks, it's really good idea.
Good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants