Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use this library in a pretty big project which has hundreds (probably more than a thousand) files we need to scan. To scan the whole source we need 15+ minutes which is a lot, especially if the code changes very rapidly.
The main issue is that to scan each domain, the library has to parse a file for each domain separately. So my solution offers the option to scan a single file only once for all the domains in a single go.
I benchmarked my solution when you need to scan 20 domains against the old way where you scan each domain individually and the difference was 12x. And that was for a simple PHP file with <50 lines. The speed gain should be even larger for JS files which need complex parsing, a lot of string operations.
I tried to implement this as an additional feature so there would be no backward compatibility issues. Currently it supports PHP/JS(VueJS) parsing.
Some minor refactoring is included too.