Blade Extractor improvement for Laravel 8/Jetstream (Gettext 4.x branch) #261
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a new Laravel 8 Jetstream project (created with
laravel new [name] --jet
), there is an exception when usingExtractors\Blade::fromFile($file, $translations);
It seems to be unable to locate the jet components, and therefore can't compile the Blade file to PHP.
i don't exactly know why it breaks, but a lot of things are recently updated regarding ComponentTag namespaces and it might be related to this error? (cf. laravel/framework@7cc120e).
However, if I'm right, the Blade extractor doesn't need to compile ComponentTag to do its job correctly, so I created this pull request to always disable it, so that the 4.x branch could still work with Laravel 8/Jetstream.
i hope that makes sense!