Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed PHP 8.1 deprecation warning #289

Merged
merged 1 commit into from Dec 11, 2022
Merged

Conversation

berrnd
Copy link

@berrnd berrnd commented Dec 10, 2022

Hi, and first thanks a lot for this library!

I've noticed another deprecation warning (ref #280) when upgrading to PHP 8.1 and fixed that here.

Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated

@oscarotero oscarotero merged commit ed5535a into php-gettext:4.x Dec 11, 2022
@oscarotero
Copy link
Member

thanks!

@berrnd berrnd deleted the php81 branch December 25, 2022 20:01
@berrnd berrnd restored the php81 branch December 25, 2022 20:02
@Smileatmaxi
Copy link

Smileatmaxi commented Aug 10, 2023

Hello There!
Have you planned to release 4.8.9 any time soon? would be awesome I could really use that fix.

Thanks ins advance!

@oscarotero
Copy link
Member

@Smileatmaxi Sorry, I completely forgot that.
I just released a new version.

@Smileatmaxi
Copy link

Smileatmaxi commented Aug 10, 2023

@oscarotero No problem, Thank you!

@Smileatmaxi
Copy link

@oscarotero Im back, could it be possible that you have burnt that 4.8.9 branch because I think you have tagged it wrong and now 5.7.0 has landed and destroyed everything.

@oscarotero
Copy link
Member

@Smileatmaxi Opps. sorry!
I just released 4.8.10 pointing to the correct branch.

@Smileatmaxi
Copy link

Awesome Thank you!

@berrnd berrnd deleted the php81 branch August 10, 2023 14:57
@berrnd berrnd restored the php81 branch August 10, 2023 14:57
berrnd added a commit to grocy/grocy that referenced this pull request Aug 10, 2023
@swissspidy
Copy link
Contributor

@oscarotero Gettext v4 supports PHP 5.4+ but this change here added the null coalescing operator to the v4 code base, which was only added in PHP 7.0. I fear that a new 4.8.11 release is needed that uses isset($value) ? $value : '' instead.

oscarotero added a commit that referenced this pull request Aug 14, 2023
@oscarotero
Copy link
Member

@swissspidy Thanks for the heads up. I just released 4.8.11 with the proposed change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants