New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why Number validator extends Url validator? #43

Closed

eusonlito opened this issue Apr 12, 2015 · 4 comments

Contributor

eusonlito commented Apr 12, 2015

https://github.com/oscarotero/form-manager/blob/master/src/Validators/Number.php#L4

Owner

oscarotero commented Apr 12, 2015

Because both use the same method to check the value: filter_var, so this avoid code duplication (https://github.com/oscarotero/form-manager/blob/master/src/Validators/Url.php#L24)

oscarotero closed this as completed

Contributor Author

eusonlito commented Apr 12, 2015

And a trait solution with this validation function? Number extending Url is strange.

Owner

oscarotero commented Apr 12, 2015

Maybe, but it's a very simple case, I don't see much benefit.

Contributor Author

eusonlito commented Apr 12, 2015

Because is not easy to remember (and strange) that Number extends Url and on future you could make changes on Url that affect to Number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment