Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relay 13 support - Rust compiler: definition of 'XYZQuery' appears to have changed #211

Closed
sync opened this issue Jan 6, 2022 · 5 comments · Fixed by #424 · May be fixed by #303
Closed

Relay 13 support - Rust compiler: definition of 'XYZQuery' appears to have changed #211

sync opened this issue Jan 6, 2022 · 5 comments · Fixed by #424 · May be fixed by #303

Comments

@sync
Copy link

sync commented Jan 6, 2022

In order to avoid having this issue when using Relay 13: facebook/relay#3437 we would need to upgrade the babel-plugin-relay to ^13.0.0.

Before I sent you a PR would have happy to include this change ? it looks like it might be a breaking change for all the non 13.x relay user.

I've tested the upgrade on a complicated relay + Vite codebase and except for this required fix everything else is working.

@oscartbeaumont
Copy link
Owner

Please send the PR through. I have been intending to release a new version of this package for a few days so once you get that though I will release an update.
I will release it as version 2.0.0 and this should help with the backwards compatibility aspect.

@sync
Copy link
Author

sync commented Jan 7, 2022

cool give me till the end of my day and I'll sent this trough in about 8 hours

@sync
Copy link
Author

sync commented Jan 11, 2022

I forgot will do this soonish. Also we now need to upgrade babel-plugin-relay to 13.0.1 and rename eagerESModules to eagerEsModules . Tested on my side with those changes everything works.

these are the relay changes: https://github.com/facebook/relay/pull/3724/files

@cliedeman
Copy link
Contributor

@oscartbeaumont Can you please check #303

@tobias-tengler
Copy link
Collaborator

My PR should address these issues, by moving the babel-plugin-relay dependency out of this plugin: #424

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants