New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
There was a problem with the alert #1898
Comments
This is a standard javascript error message that is very fast, simple and effective and works on every device out there. You are, however, free to modify your theme any way you like. You cannot have 2 exactly the same (duplicate) searches saved, this is normal. |
Hello dev-101. You missed the whole idea. It is not ok to have error messages inside forms (like register) + flash errors (red ones bellow header) + this java errors. This is a matter of unify all of them into a single type of display (not 3 as we have now). In addition, users may check by mistake the option "Prevent this page from creating ....." and they will not receive any more error message when they do something wrong. Is this ok to you? On which major script did you see something like this? |
Hi Adyyda, yes I understand, but the thing is flash messages are server-side generated, and javascript validations are client-side generated. You can remove/modify your java messages inside theme to mimic flash messages styles. |
This should be unified and fixed at core level, not at theme level. Osclass is very good in many areas but on this area fails miserable. I have't see 3 types or messages in any auctions/ classifieds scripts. All of them have just 1, regardless their point of origin. |
This has to be fixed at theme level, as it's an ajax request and the response is handle by the theme. |
1.Users must not see 2 types of error messages - the usual flashmessage shown inside theme and the ones from the image. Please convert the type from the image into the flashmessage. This happens in all areas including post a item.
Beside this, if you click several times on these non flashmessage messages, user will see the checkbox and if they check it and save, they will not receive the error messages any more.
2.Another issue regarding Subscribe to this search
If i have logged in and perform a search i can save it just fine. The problem is that there is no message in that area telling users that the search is already saved and so, users may try to save it again and when they try they will not be able. They will get only the non flashmessage message "There was a problem with the alert". So no message that tells them that they already saved that search.
Please take a look at a fully working implementation done in http://olx.in/all-results/
The text was updated successfully, but these errors were encountered: