Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap: layouts for viewing a member, offer or req #405

Closed
herestomwiththeweather opened this issue Jul 16, 2013 · 4 comments
Closed

Comments

@herestomwiththeweather
Copy link
Collaborator

in the bootstrap branch, the views for a single member, offer or req do not have a good layout.

@herestomwiththeweather
Copy link
Collaborator Author

some ideas to improve the layout on these 3 views.

i. offer - e.g. https://demo.opensourcecurrency.org/groups/21#offers/45

a. two columns instead of one with the picture on the left column and text on the right.

b. move the category from the main text to above the subject heading and prefixed with something like "Listed in"

c. maybe instead of the description being in the right column, it should be underneath the two columns in a new row/div.

ii. req - e.g. https://demo.opensourcecurrency.org/groups/21#reqs/473

a. people don't normally include a picture for a req, so currently a small image of the requestor is displayed. maybe this image should be moved to give it less visibility so that attention is drawn to the description of the request instead.

b. move the category from the main text to above the subject heading and prefixed with something like "Listed in"

c. maybe the new bid form should be in a 2nd column on the right.

d. the rows of text seem to be too close together vertically.

e. the distance from the requestor is currently displayed. if either the requestor or viewer has not provided their address, the distance will often be many thousands of miles away since the default location is Area 51. it seems this distance should be omitted if it is sufficiently large (maybe > 300 miles)

iii. person/member - e.g https://demo.opensourcecurrency.org/groups/21#memberships/52

this view is currently the worst as activity is currently just placed adjacent to the person's image and doesn't stay within a column. maybe this activity should be underneath the photo and maybe the description should be in a new column on the right.

a person will often be associated with several categories so it might not be good to put it above the header as with the offers and reqs.

@ziyan-junaideen
Copy link
Collaborator

Ref: i) b)
I believe you are looking to display them like Listed in: Category 1, Category 2. Am I correct? The current content is categories are generated using two helper functions. Is the use of a new function to generate the desired output acceptable?

@herestomwiththeweather
Copy link
Collaborator Author

yes, comma separated instead one category per line which is how formatted_req_categories() displays. a new function is a good idea. it also seems like the font for the categories list here should be a little smaller since they are moving to right above the name of the request.

@herestomwiththeweather
Copy link
Collaborator Author

This seems to be done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants