-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Content is overflowing at the bottom which results in a content leak on Notch phones #11
Comments
For future readers, a workaround is:
Overriding the zIndex doesn't seem to work even if the value is greater than 100 which is what seems to be set for this component. |
Thanks, I have no opinion how to deal with now, but I'm going to figure it out soon. |
what is the proper solution for this? |
I think that @Eyesonly88 is good. Need to dig into it a bit |
Doesn't work. Tested in iPhoneX. snapPoints percentage also gets messed up with SafeAreaView. |
if you are using nativebase ui library then put bottomsheet inside component. |
any updates on this? |
The Here's my pretty hacky, hopefully temporary solution. I've added an empty <Fragment>
<SafeAreaView>
<BottomSheet ... />
</SafeAreaView>
<SafeAreaView style={{backgroundColor: 'white'}}>
</Fragment> Edit: The |
you can use snapPoints={[100, -100]} in BottomSheet. |
There is no fix yet, the workaround is; const insets = useSafeAreaInsets();
<BottomSheet
containerStyle={{
marginTop: insets.top,
marginBottom: insets.bottom,
}}
ref={bottomSheetRef}
snapPoints={snapPoints}
> |
First of all, awesome library 馃憦
I've come across what I think is a bug where the bottomSheet content is leaking into the
SafeArea
from the bottom (on notch phones like iPhone X).SafeArea
is a component fromreact-navigation
that ensures content is not overlapping outside of viewable area in notch phones.Preview
You can see the bottom sheet content is overflowing at the bottom when it should not be.
Here's my configuration:
react-native info
Things I tried
I tried setting zIndex on the
SafeArea
view to a high value like 9 but still, the bottom sheet is showing on top.Any other ideas I can try to work around this?
Thanks 馃憢
The text was updated successfully, but these errors were encountered: