Change unfollow to stop-following #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is IMP-647 |
erincandescent
added a commit
that referenced
this pull request
Apr 25, 2014
IMP-647 #resolve Change unfollow to stop-following
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you stop following a user, the standard verb of this activity (used by other clients) is “stop-following” (according to http://activitystrea.ms/head/activity-schema.html#verbs), but impeller posts it as “unfollow”, which is not included in ms_verbStrings for localization.
So we are in a curious situation where Impeller doesn't understand it's own activities.
We could either add “unfollow” to ms_verbStrings and point it to the same localized string as “stop-following”, or we can change it to “stop-following” comply with the activitystrea.ms standard. I would say this solution has the advantage of compatibility with other pump.io clients. Introducing new verbs for the same action would add more complexity other developers will have to deal with if they want to parse actions or implement i18n in their applications.