Incorrect Logical Core/Logical Processor count information

[RajeshPutta87]

I am from AppDynamics. We are using OSHI 5.1.0 to retrieve CPU, Memory, Processor, Process information and the environment in use is name=Windows, release=Microsoft Windows Server 2016 Standard, architecture=64-bit

Environment in test is having

64 physical cores
128 logical cores/logical processors

OSHI is incorrectly reporting logical cores as 126 instead of 128. Please refer to attached screenshots and processor details

Can you please look into the issue.

processor.txt

Thanks
Rajesh

[dbwiddis]

OK, I've tracked this one down to this iteration in the LogicalProcessorInformation class:

for (int lp = lowBit; lp <= hiBit; lp++) {
  if ((mask & (1L << lp)) > 0) {
    // adds a core to the list
  }
}

This fails on core 63, which is a long with a 1 followed by 63 zeroes. This works out to Long.MIN_VALUE which is not > 0.

That comparison should be != 0.

[RajeshPutta87]

@dbwiddis I have made changes to getLogicalProcessorInformation, getBitMatchingPackageNumber, getMatchingCore,getMatchingNumaNode,getMatchingPackage,getLogicalProcessorInformationEx from LogicalProcessorInformation class

Please review it and let me know if that looks fine. I have build the jar with those changes. Also please confirm if those changes fix even #1361

[dbwiddis]

Resolved in #1362. #1361 is a separate issue that this doesn't fix.