Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Add variables command #1172

Merged
merged 4 commits into from
Sep 9, 2022
Merged

Conversation

enmaboya
Copy link
Contributor

You will probably add variables to the .env one way or another.

This command just simplifies the this process

@gnikyt
Copy link
Owner

gnikyt commented Sep 9, 2022

@enmaboya I am fine with this! Maybe the command should be shopify-app:variables:generate? Been looking at how other pkgs do commands, seem to be more along the lines of namespace:section:action.

Approving running the actions too, so we can see test results.

@gnikyt gnikyt self-assigned this Sep 9, 2022
@gnikyt gnikyt added the feature Enhancement to the code label Sep 9, 2022
@gnikyt
Copy link
Owner

gnikyt commented Sep 9, 2022

Hmm not sure why actions is not showing up for this PR... @Kyon147 have you seen this happen before?

@Kyon147
Copy link
Collaborator

Kyon147 commented Sep 9, 2022

@osiset that is strange, we might need to do a blank commit and push in this PR to trigger them. Github might have just had a wobble.

@gnikyt
Copy link
Owner

gnikyt commented Sep 9, 2022

@Kyon147 That solved it :/

@gnikyt
Copy link
Owner

gnikyt commented Sep 9, 2022

@enmaboya Merged. Maybe add a wiki entry about it if you get time to explain what it does... we probably need a page to explain all commands existing (like this one and webhook) in the future.

@gnikyt gnikyt merged commit 6ebe131 into gnikyt:master Sep 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature Enhancement to the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants