Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Setting up Iframe protection #1178

Merged
merged 8 commits into from
Sep 3, 2022

Conversation

enmaboya
Copy link
Contributor

At the moment, if you do not set some of the headers, the application will not pass the review.

This header (frame-ancestors) allows you to open the application in an iframe only from an allowed domain

@Kyon147
Copy link
Collaborator

Kyon147 commented Aug 26, 2022

@enmaboya if you pull in master, it should fix the issue with the allowed plugins error but you'll need to fix the linting issue still.

@enmaboya
Copy link
Contributor Author

@Kyon147 linting has been updated

@Kyon147
Copy link
Collaborator

Kyon147 commented Aug 29, 2022

Thanks @enmaboya

Could you also write a test for your new code, as the coverage drops by 1% due to the file being included.

image

We should be good after a test it written that covers your new code.

@enmaboya
Copy link
Contributor Author

enmaboya commented Sep 3, 2022

@Kyon147 test added

@Kyon147
Copy link
Collaborator

Kyon147 commented Sep 3, 2022

Thanks for your work on this @enmaboya 👍

@osiset can you take a look at approve too, it will be good to get this out with laravel 9 as this blocks app store approvals at the moment without the iframe protection.

@gnikyt
Copy link
Owner

gnikyt commented Sep 3, 2022

@Kyon147 Just reviewed it, I am good with it to merged in!

@Kyon147
Copy link
Collaborator

Kyon147 commented Sep 3, 2022

Thanks @osiset will sort it out later to master and it can be part of the next release candidate for laravel 9 support. Will sort v17.2.0 next week so we can have the new version out.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants