feature/cookieless #847
feature/cookieless #847
Conversation
* Combining AuthShopify, AuthToken into new VerifyShopify middleware * SessionToken value object created to verify and validate all aspects of the JWT * New unauthenticated route and view added
* VerifyShopify: Cleaned up methods to be smaller and clearer * VerifyShopify: Handle cases for no token, no hmac * VerifyShopify: Adjusted to not rely on ShopSession service anymore.
* Moved AuthorizeShop to InstallShop * Condensed InstallShop and modified to return an array * Modified InstallShop to track access token update time * Modified Shop command to track access token update time
* Removed authenticate.oauth route * Removed oauthfailure method on authenticate controller * Removed ShopSession class * Updated shopify-config to reference new authenticate routes (install, token) * Updated shopify-config to remove old authenticate routes * Updated ShopModel's getToken to getAccessToken for naming conflict purposes * Removed old ITP and authenticate routes from built-in route provider
* Added test for `tokenRoute` * Added test for `tokenRedirect` * Modified `TokenRedirect` and `TokenUrl` macros to use a common base class
…y into feature/cookieless
* Ignore `factory()` in tests * Ignore `tokenRoute` static method in src as it is dynamic macro * Ignore `tokenRedirect` static method in src as it is dynamic macro
|
@lucasmichot I am fine with all the changes currently.
Only thing missing from this branch is the "per-user" auth abilities... I think this can be a minor release to add the feature after this big release is out. |
Hey @osiset, yes I would totally merge this and create a new major release, as lots of BC have been introduced. Also I very agree with you on adding "per-user" auth ability later Plenty of things can also be added/improved later - but at least the new release would have a fresh new codebase to work on 👍 |
Co-authored-by: Lucas Michot <lucas@semalead.com>
Solid. Yeah good suggestion. Going for the merge! |
|
@osiset On the v17.0.0 release in the "Internal" section you mention |
Your correct, will update :) |
|
OK great, thank you! I just wanted to make sure I wasn't missing something I wasn't aware of 😬 |
mastersuch as helpers movedUtils, CI and analysis improvements, and moreMany months of work from various contributors! PR is ready to be reviewed and merged if all is well.