Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A huge security hole in OrdersController #183

Closed
ghost opened this issue Nov 25, 2022 · 2 comments
Closed

A huge security hole in OrdersController #183

ghost opened this issue Nov 25, 2022 · 2 comments
Labels

Comments

@ghost
Copy link

ghost commented Nov 25, 2022

In OrdersController - InitOrder I can pass any product price, different than a real product price and your application accepts it. There is no validation.

@oskardudycz
Copy link
Owner

It’s intended, as Orders API should only be used internally through the Saga. It should use the frozen price the consumer confirmed in the shopping cart.
Do you have a recommendation on how you would implement that differently?

@oskardudycz
Copy link
Owner

Closing it for now, with the justification as above. I'm willing to reopen it after the feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant