Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manifest for oskarstark/php-cs-fixer-ga:null #103

Closed
emodric opened this issue Sep 6, 2023 · 11 comments
Closed

Manifest for oskarstark/php-cs-fixer-ga:null #103

emodric opened this issue Sep 6, 2023 · 11 comments

Comments

@emodric
Copy link
Contributor

emodric commented Sep 6, 2023

Hi, I saw that you now automatically provide a newest version of PHP CS Fixer, but I'm not sure how this is supposed to work. I get the following errors now with my unchanged config.

Pull down action image 'oskarstark/php-cs-fixer-ga:null'
  /usr/bin/docker pull oskarstark/php-cs-fixer-ga:null
  Error response from daemon: manifest for oskarstark/php-cs-fixer-ga:null not found: manifest unknown: manifest unknown
  Warning: Docker pull failed with exit code 1, back off 6.43[2](https://github.com/netgen-layouts/layouts-core/actions/runs/6095240765/job/16538389536#step:2:2) seconds before retry.
  /usr/bin/docker pull oskarstark/php-cs-fixer-ga:null
  Error response from daemon: manifest for oskarstark/php-cs-fixer-ga:null not found: manifest unknown: manifest unknown
  Warning: Docker pull failed with exit code 1, back off 5.4[3](https://github.com/netgen-layouts/layouts-core/actions/runs/6095240765/job/16538389536#step:2:3)8 seconds before retry.
  /usr/bin/docker pull oskarstark/php-cs-fixer-ga:null
  Error response from daemon: manifest for oskarstark/php-cs-fixer-ga:null not found: manifest unknown: manifest unknown
Error: Docker pull failed with exit code 1
@OskarStark
Copy link
Owner

I tried to fix the workflow myself, let's see how things are going:
https://github.com/OskarStark/php-cs-fixer-ga/actions/runs/6096486361

@OskarStark
Copy link
Owner

Looks like it works somehow and is green, but no tag is created 🤷🏼‍♂️

@OskarStark
Copy link
Owner

Ah ok, No need for a tag or a release on GitHub yet, the docker image on docker hub gets created as latest, so this should work now.

I think it would be nice to also tag the correct version.

Will have a look next week 👍🏻

@emodric
Copy link
Contributor Author

emodric commented Sep 11, 2023

@OskarStark Is there something I need to do on my side, because it still fails, but now with a different error

https://github.com/netgen-layouts/layouts-core/actions/runs/6095387977/job/16668014443

Thanks!

@OskarStark
Copy link
Owner

Can you try "latest" as version string?

@emodric
Copy link
Contributor Author

emodric commented Sep 12, 2023

Works now, thanks! 👍

@emodric emodric closed this as completed Sep 12, 2023
@OskarStark
Copy link
Owner

Just for my understanding, latest works, while a dedicated version not, right?

@emodric
Copy link
Contributor Author

emodric commented Sep 13, 2023

Actually, it was not issue with the version, as it turns out, I forgot to let you know, as I was trying different formats, so I wasn't actually sure what really helped.

So I took a look at it again and the issue was using the old uses notation in action config:

-      - uses: OskarStark/php-cs-fixer-ga@master
+      - uses: docker://oskarstark/php-cs-fixer-ga

@OskarStark
Copy link
Owner

OK, but does this work?

- - uses: docker://oskarstark/php-cs-fixer-ga
+ - uses: docker://oskarstark/php-cs-fixer-ga:latest

and

- - uses: docker://oskarstark/php-cs-fixer-ga
+ - uses: docker://oskarstark/php-cs-fixer-ga:3.25.1

?

@emodric
Copy link
Contributor Author

emodric commented Sep 13, 2023

latest works fine, but specifying the version directly does not. I don't know if it's an issue with version 3.25.1 specifically.

@OskarStark
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants