Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use of non-minified vue.js to allow debugging #6

Open
johanbrandhorst opened this issue Feb 4, 2017 · 9 comments
Open

Allow use of non-minified vue.js to allow debugging #6

johanbrandhorst opened this issue Feb 4, 2017 · 9 comments

Comments

@johanbrandhorst
Copy link

The vue devtools requires the vue.js file to be in "non-production" mode. Currently the version used is minified, which makes it impossible to use the debugging tools, which is a shame.

@oskca
Copy link
Owner

oskca commented Feb 24, 2017

Maybe I shall not include the VueJS in the GopherJS package directly?

@johanbrandhorst
Copy link
Author

That would be another alternative

@oskca
Copy link
Owner

oskca commented Feb 24, 2017

It's done by 2ff578c @johanbrandhorst

@johanbrandhorst
Copy link
Author

Thanks! I think you should probably add it to your README as well so users aren't confused why their code doesn't work. This means another setup step is to download a suitable version of vue.js and name it the correct thing and put it in the right place, so it should be in the README.

@oskca
Copy link
Owner

oskca commented Feb 25, 2017

as in ab40c9e, you can now use building tags to switch the VueJS versions. 😄

@johanbrandhorst
Copy link
Author

Nice work!

@johanbrandhorst
Copy link
Author

johanbrandhorst commented Feb 25, 2017

Actually I have to reopen this as no matter how I try I can't seem to get it compiled with the minified version?

@oskca
Copy link
Owner

oskca commented Feb 26, 2017

When switching the building tags the building procedures works as expected, but the outcomes always include only one version of the *.inc.js code. I think this's a bug of gopherjs building tools, and filed an issue report: gopherjs/gopherjs#598.

@johanbrandhorst
Copy link
Author

Ah, good digging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants