Skip to content
This repository has been archived by the owner on Jun 3, 2020. It is now read-only.

Calling twice LabeConnector shoudn't end in two overlaid connectors #10

Closed
haubourg opened this issue May 20, 2019 · 3 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@haubourg
Copy link
Contributor

Current logic applies a new geometry generator each time.
We could set tags into the geometry expression so that if a geometry generator is already there, with the tags, the plugin would only replace the expression

It is also a possibility to explain user where the expression comes from :

image

@haubourg haubourg added the bug Something isn't working label May 20, 2019
@lbartoletti
Copy link
Contributor

Current logic applies a new geometry generator each time.

Is generated twice if the current style have already an expression for our plugins.

I had seen this in my tests, but I didn't worry about it, since I think it was my responsibility as a user to verify the behavior of the new style or to apply it from a style that didn't contain these arrows.

So, yes, we can verify if the style already has a geometry of the plugin, but what should we do next?

Some questions I had asked myself:
Is it prevented? Does the user want to customize a second arrow according to a condition?
Is it definitely a bug? Isn't it the responsibility of the user to control it?

It is also a possibility to explain user where the expression comes from :

Good Idea!

@lbartoletti
Copy link
Contributor

It is also a possibility to explain user where the expression comes from :

Good Idea!

Done in 3ae3e2b

@haubourg
Copy link
Contributor Author

Nice, works smoothly

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants