Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numeric rule - direction value contains special character (semicolon ";") #751

Closed
sun-geo opened this issue Feb 6, 2020 · 8 comments
Closed

Comments

@sun-geo
Copy link

sun-geo commented Feb 6, 2020

Hi together,

i'm wondering if a node object which has a direction information like direction=90;270
( example osm ojbect: https://www.openstreetmap.org/node/6758704280 )
is wrong like there is a rule
(the item and class number, http://osmose.openstreetmap.fr/en/errors/?item=9006 )
which is saying that "unusual value of direction".

https://osmose.openstreetmap.fr/en/error/2f715950-3b8f-f17c-6008-c3a9d9d3c0dc
https://osmose.openstreetmap.fr/de/map/#item=9006&zoom=17&lat=34.641377&lon=-102.741073&level=1%2C2%2C3&tags=&fixable=

Even the iD-Editor supports these semicolon separated direction values by drawing/rendering cones to the object, see here:
https://www.openstreetmap.org/edit?node=6758704280
cones

Please consider to don't warn about these situations.

@sun-geo sun-geo changed the title numeric rule - direction value contains special charcter (semicolon ";") numeric rule - direction value contains special character (semicolon ";") Feb 9, 2020
@frodrigo
Copy link
Member

frodrigo commented Feb 9, 2020

This check come from JOSM validator "numeric".

cc @Klumbumbus

@Klumbumbus
Copy link

The rule in general supports semicolons, but not with two single values. I'll have a look if I can adjust the regexp accordingly: https://josm.openstreetmap.de/browser/josm/trunk/data/validator/numeric.mapcss#L278

@sun-geo
Copy link
Author

sun-geo commented Feb 9, 2020

Thank you both, for checking this.

@frodrigo
Copy link
Member

@Klumbumbus can I close this issue?

@Klumbumbus
Copy link

Yes, you can close it. I didn't have time/motivation to look at this, however I moved the issue here: https://josm.openstreetmap.de/ticket/18765

@Klumbumbus
Copy link

Fixed in JOSM in https://josm.openstreetmap.de/changeset/15965

@sun-geo
Copy link
Author

sun-geo commented Mar 1, 2020

@Klumbumbus
Thanks a lot.

@frodrigo
This JOSM change will also modify the corresponding osmose rule?

@frodrigo
Copy link
Member

frodrigo commented Apr 7, 2020

MapCass updated on Osmose side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants