Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Names of linked places should be searchable #2500

Closed
Janjko opened this issue Oct 29, 2021 · 4 comments
Closed

Names of linked places should be searchable #2500

Janjko opened this issue Oct 29, 2021 · 4 comments

Comments

@Janjko
Copy link

Janjko commented Oct 29, 2021

What did you search for?

https://nominatim.openstreetmap.org/ui/search.html?city=Vela+Luka
https://nominatim.openstreetmap.org/ui/search.html?city=Vela+Luka&country=Croatia

What result did you get?

No results

What result did you expect?

https://www.openstreetmap.org/node/95241963

Further details

If I put the county as a search term, the boundary of the city is found, but the node is still not found:

https://nominatim.openstreetmap.org/ui/search.html?city=Vela+Luka&county=Dubrovnik-Neretva+County

@lonvia
Copy link
Member

lonvia commented Oct 30, 2021

The Vela Luka node gets merged with the relation "Općina Vela Luka" because both have the same wikidata tag, indicating they are the same place. So far so good. The problem then is that the names from the relation take precedence and those names all include the category indicator (opcina/commune) which then makes your search a search for a partial term. And that goes wrong here because 'vela' and 'luka' are very frequent terms.

We really need to keep both sets of names when merging place nodes and boundary relations.

@Janjko
Copy link
Author

Janjko commented Oct 31, 2021

Well, I'm not sure the town should have the same wikidata tag as the municipality. The wikipedia article talks only about the town Vela Luka, not about the few extra hamlets in the municipality. I think I'll remove the wikidata tag from the relation.

I'm guessing the merging will create a lot of searching mistakes because I have a felling lots of mappers will add the same wikidata tag to both. Maybe I'm wrong.

Anyway, I removed the wikidata tag and now it works. Thank you very much!

@Janjko Janjko closed this as completed Oct 31, 2021
@lonvia lonvia changed the title Vela Luka not found Names of linked places should be searchable Oct 31, 2021
@lonvia
Copy link
Member

lonvia commented Oct 31, 2021

The linking was likely fine from a point of a search engine. The wikipedia article at least is certainly about the municipality and town.

In any case, the issue of making sure tht names of linked places are searchable remains. Reopening.

@lonvia
Copy link
Member

lonvia commented Mar 17, 2022

Fixed in #2637.

@lonvia lonvia closed this as completed Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants