Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for key "lock_name" #3365

Open
philippelatulippe opened this issue Mar 16, 2024 · 1 comment
Open

Support for key "lock_name" #3365

philippelatulippe opened this issue Mar 16, 2024 · 1 comment

Comments

@philippelatulippe
Copy link

Problem

Locks are tagged as regular waterways with an additional tag lock=yes. This means that their name tag is often simply the name of the river or canal, while the name of the lock itself is tagged in lock_name, as recommended in Key:lock. Nominatim doesn't see this tag, so these locks cannot be searched for by name.

Solution

Add the key lock_name to the list of tags that are considered names.

Alternatives

Couldn't think of any. Hopefully this is a straightforward solution.

Additional context

Searching for the name of a lock is useful not just for boaters, but also for regular folks who live in cities that have many of them, where they are often gathering places. The name of locks are also mentioned in the news and blogs posts, for instance the Weerdsluis which is often talked about internationally due to its 'fish doorbell'.

@lonvia
Copy link
Member

lonvia commented Apr 1, 2024

If only the tag name was lock:name, then it could be easily handled in the same way as bridge:name but it looks like the tag vastly predates the introduction of the colon notation.

I'm tempted to just internally rewrite the tag to lock:name. The drawback is that it would then also show up like this in the details and people might wonder where the tag comes from.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants