Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile.in with svnversion #15

Closed
terexas opened this issue Jun 18, 2012 · 3 comments
Closed

Makefile.in with svnversion #15

terexas opened this issue Jun 18, 2012 · 3 comments

Comments

@terexas
Copy link

terexas commented Jun 18, 2012

The nominatim/Makefile.in is a bit incorrect if you get the sources from git. The version is set using svnversion:

SVN:=$(shell svnversion) CFLAGS += -DVERSION=\"$(VERSION)-$(SVN)\"

Means, if sources are from git and svnversion is installed on system, CFLAGS on make is set to -DVERSION="0.1-Unversioned directory". Here GCC fails with following message as it treats the string as 2 separate words:

gcc: error: directory": No such file or directory

System:
gcc (GCC) 4.7.0 20120507 (Red Hat 4.7.0-5)
svn, version 1.7.4 (r1295709)
Linux 3.4.0-1.fc17.x86_64
Fedora 17

@lonvia
Copy link
Member

lonvia commented Jun 26, 2012

I'm currently reworking the configure system. The issue should be fixed there.

It would be very helpful if you could test if the restructured configure works without problems in Fedora. The branch and new compilation instructions can be found in the pull request.

@terexas
Copy link
Author

terexas commented Jun 27, 2012

Tested with pull request patch https://github.com/twain47/Nominatim/pull/14.patch.
Compiles without any issues.

@lonvia
Copy link
Member

lonvia commented Jun 27, 2012

Awesome, thanks for testing. New configure is now merged.

@lonvia lonvia closed this as completed Jun 27, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants