Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lua multipolygon handling #29

Closed
pnorman opened this issue May 16, 2013 · 2 comments
Closed

lua multipolygon handling #29

pnorman opened this issue May 16, 2013 · 2 comments

Comments

@pnorman
Copy link
Collaborator

pnorman commented May 16, 2013

Difference found: ways in a MP where inner, outer and relation are tagged with landuse=forest. I don't have a problem with lua's handling, the tagging is unclear. Also, a broken import.

Way in question: http://www.openstreetmap.org/browse/way/42234367

tile.osm.org 13/4259/2850

lua 13/4259/2850

@apmon
Copy link
Contributor

apmon commented May 16, 2013

I think the lua handling is correct in this case.

The inner way is also marked as landuse=forrest. So my guess is what happens is that it creates a multi-polygon with the inner way correctly cut out, but then renders a separate landuse=forest for the inner way according to its tagging, making it look like there is no cut out

@apmon
Copy link
Contributor

apmon commented Sep 8, 2013

After the lua script changes from yesterday is this still valid. The lua script now passes all of the multi-polygon tests. So if there are still differences, the test cases need expanding

@pnorman pnorman closed this as completed Sep 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants