Crash on selecting Wallraf-Richartz-Museum

[DujaOSM]

Description

Whenever I try to locate or select the object "Wallraf-Richartz-Museum & Foundation Corboud" (Cologne, Germany), OsmAnd (4.5.5) for iOS (17.1.1) crashes.

The issue can be reliably reproduced every time, with every map style.

The exception is recorded in the log, which I'll provide soon (substring ToIndex: Index 168465135768268664 out of bounds, string length 23 being the main culprit).

Steps to reproduce

1. Download the Cologne region (North Rhine-Westphallia map)
2. Search for "Wallraf-Richartz"
3. Select "Wallraf-Richartz-Museum & Foundation Corboud"
4. The application crashes

OsmAnd also crashes when you locate the museum manually (e.g. by finding "Wallraf-Richartz Cafe") and tap the building.

Actual result

Crash

Expected result

No crash

Your Environment (required)

OsmAnd Version: 4.5.5
Android/iOS version: iOS 17.1.1
Device model: iPhone 13 mini
Crash-Logs:
2023-11-27 10:09:30.779 OsmAnd Maps[19560:3207740] >> Search phrase wallraf 29
*** Terminating app due to uncaught exception 'NSRangeException', reason: '*** -[__NSCFString substringToIndex:]: Index 18446744073709551615 out of bounds; string length 23'
*** First throw call stack: (0x196cdc870 0x18effbc00 0x195bb9804 0x1015aa494 0x1015ab124 0x197cce7b4 0x197cec6d0 0x19ebab6a8 0x19ebad300 0x19ebb4894 0x19ebb53f8 0x19ebc0004 0x19ebbf878 0x20064d964 0x20064da04) libc++abi: terminating due to uncaught exception of type NSException

[DmitryAlexei]

Testflight 4.6.2.1. iPhone 13 mini (17.1.1) and iPhone 6s (15.7.7)

Steps to reproduce:

• search for Koln and go to that city
• download Cologne region map
• search for Wallraf- Richartz
• choose Wallraf-Richartz museum and go to POI Context menu
• expand Images nearby tab (if needed)

Actual result:

• app crashes (see video)
• If Images nearby tab has already been expanded in other POI, app crashes immediately after opening POI Context menu
• same result for iPhone 13 and 6s
• same result for Brandburger Tor in Berlin
• no crash when only Mapillary images are present

video_2023-11-28_10-26-34.mp4

Expected result:

• no crash
• images nearby displayed

[dmpr0]

[DmitrySvetlichny]

https://github.com/osmandapp/OsmAnd-iOS/pull/3257/files