Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor leftside: Routing avoids junction=circular with oneway=no #13497

Open
Famlam opened this issue Jan 8, 2022 · 5 comments
Open

Refactor leftside: Routing avoids junction=circular with oneway=no #13497

Famlam opened this issue Jan 8, 2022 · 5 comments
Milestone

Comments

@Famlam
Copy link
Contributor

Famlam commented Jan 8, 2022

Description

junction=circular, unlike junction=roundabout, doesn't have to be oneway=yes. However, it seems that OsmAnd treats it as oneway=yes, even though it is explicitly set to oneway=no

How to reproduce?

  1. Navigate from this position to this position by bike
    (e.g. https://www.openstreetmap.org/directions?engine=fossgis_osrm_bike&route=51.88244%2C5.85196%3B51.88290%2C5.85142#map=19/51.88271/5.85184 )
  2. Notice that OsmAnd will route you a long way around, just so it can avoid the oneway=no part. See screenshot:
    Detour

Suspect these two lines are to blame:
https://github.com/osmandapp/OsmAnd-resources/blob/5d86a3d42b5a94c55089bbe81ba6264421594803/obf_creation/rendering_types.xml#L1757-L1758

Your Environment

OsmAnd Version: 4.1.11
Android/iOS version: Android 11
Device model: LG

Maps used (online or offline):
If you have an issue related to offline maps, tell us the exact name of the map file where the issue occurs and its edition date.
Offline: Netherlands, Gelderland, January version

@Famlam

This comment was marked as outdated.

@vshcherb vshcherb modified the milestones: 4.2-android, 4.2-backend Jan 13, 2022
@vshcherb
Copy link
Member

vshcherb commented Jan 13, 2022

  1. we can fix accept pr at least (indeed should be part of routing.xml)
  2. is a completely different area of how to compute and display turn exit which we need to fix anyway... right now we detect direction from user settings and not from the real geometry of the junction, so it could be part of this fix. But it's a complicated fix )))

@Famlam
Copy link
Contributor Author

Famlam commented Feb 8, 2022

  1. we can fix accept pr at least (indeed should be part of routing.xml)

Proposed one. I can't do the second point as it's (as you mention) very complicated

@vshcherb
Copy link
Member

vshcherb commented Feb 8, 2022

Merged. 2-nd will work automatically as counter but visual display won't

@vshcherb
Copy link
Member

vshcherb commented Feb 8, 2022

I will leave the issue open, so we can do internal refactoring to:

  1. Remove leftSideNavigation parameter from routing completely (leave only in UI to display turns)
  2. As a result of routing calculate what likely leftSideTurn or rightSideTurn (roundabout) is.

@vshcherb vshcherb modified the milestones: 4.2-backend, 4.3-backend May 10, 2022
@vshcherb vshcherb modified the milestones: 4.3-backend, 4.4-backend Oct 2, 2022
@vshcherb vshcherb changed the title Routing avoids junction=circular with oneway=no Refactor leftside: Routing avoids junction=circular with oneway=no Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants