Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenGL: Pinch zoom to magnify text fails #15034

Open
sonora opened this issue Aug 8, 2022 · 6 comments
Open

OpenGL: Pinch zoom to magnify text fails #15034

sonora opened this issue Aug 8, 2022 · 6 comments
Labels
Nice to Have Should be fixed but there is no priority or no possibility to fix it within current horizon planning

Comments

@sonora
Copy link
Member

sonora commented Aug 8, 2022

It may not be easy to fix, but let me trigger the investgation anyway: Using legacy rendering, if in bad light conditions like direct sunlight, and trying to read text on the map, you can use "pinch zoom and hold", i.e. pinch-zooming the map and leaving your fingers in position, to temporarily magnify a map area (including all text) without it getting re-rendered, this e.g. facititates reading small or tilted map text.

Using OpenGL rendering, this trick fails, because map text immediately disappears during the maneuver, thus is never magnified.

Any chance to fix OpenGL to support that trick again?

@vshcherb
Copy link
Member

vshcherb commented Aug 8, 2022

This wouldn't work with Intermediate zoom feature which we plan to fix. So text should be increased only with a setting of Text size.

@vshcherb vshcherb added the Observed Needs more clarification, feedback, or research label Aug 8, 2022
@vshcherb
Copy link
Member

vshcherb commented Oct 2, 2022

#15009

@vshcherb vshcherb closed this as completed Oct 2, 2022
@vshcherb vshcherb removed the Observed Needs more clarification, feedback, or research label Oct 2, 2022
@sonora
Copy link
Member Author

sonora commented Mar 5, 2023

Let me perhaps reopen this to see if we can find a solution.

This issue is about (with the OpenGL engine) being able to use pinch zoom as an on-the-fly screen magnifier, like the V1 engine allows. (For text, contour lines, etc. in difficult lighting.)

The basic idea so far was if we could not simply during a pinch zoom action pause displaying the re-rendered screen content (produced in the background by the GPU) until the user takes the fingers off the screen, and before that simply display the scaled former bitmap.

We had interim linked this to #15009, but unfortunately the fix for that one did not solve this issue here.

@sonora sonora reopened this Mar 5, 2023
@vshcherb vshcherb added the Nice to Have Should be fixed but there is no priority or no possibility to fix it within current horizon planning label Mar 6, 2023
@vshcherb
Copy link
Member

vshcherb commented Mar 6, 2023

I still don't think we should change anything, I don't think it's important feature but let's keep it open

@Gregor0000
Copy link

I think this feature is quite important and it is one of the major reasons, I don't use OpenGL rendering yet.
It is so convenient to be able to increase the text size with pinch&zoom in situations where the readability of the screen is bad (bad light - too dark, too bright, when wearing sunglasses). For me, those situations happen all the time during my hikes. Increasing the overall text size is not a good solution: It clutters the map view and makes a good overview more difficult.
I would very much appreciate if such a functionality could be implemented.

@sonora
Copy link
Member Author

sonora commented Mar 27, 2023

@Gregor0000 Exactly.

And it"s not just for text. It temporarily magnifies everything, e.g. also contour lines, which normally you may only have as a background feature with intentionally less visibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Nice to Have Should be fixed but there is no priority or no possibility to fix it within current horizon planning
Projects
None yet
Development

No branches or pull requests

3 participants