Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't announce small double turns #15195

Open
scaidermern opened this issue Aug 31, 2022 · 5 comments
Open

Don't announce small double turns #15195

scaidermern opened this issue Aug 31, 2022 · 5 comments

Comments

@scaidermern
Copy link
Contributor

Sometimes you have to turn left and immediately right again (or vice versa), for example in the following situation:

foo
https://www.openstreetmap.org/#map=18/51.31641/13.11360

OsmAnd currently announces this as something like "turn left, then keep right". This can be quite confusing for the user since in reality these intersections often appear very close to a straight line. Instead, OsmAnd could just omit such small double turns and simply announce "go straight ahead". This will be both shorter and clearer in many cases.

@vshcherb vshcherb added this to the future-backend milestone Aug 31, 2022
@vshcherb
Copy link
Member

Very tricky... Potentially we could have bugs due to non-precise micromapping.

@scaidermern
Copy link
Contributor Author

I agree that some cases might be tricky. However, overall I think skipping such announcements (up to a certain distance between double turns) might have more advantages than disadvantages.

I'd like to hear other opinions about this.

@mikehgentry
Copy link

Some wording like "Cross X Street and continue along Y street" might be even clearer? Obviously only if it's actually a different road.

@dktue
Copy link

dktue commented Sep 7, 2022

I agree that detection of those double turns is hard but it's definitely something I also did observe myself. Would be a welcome improvement.

@sonora
Copy link
Member

sonora commented Sep 7, 2022

We do something similar already by combining successive turns towards the same direction if within a certain threshold distance., i.e. that method could be tweaked. Trouble is it is hard to judge what ground truth looks like, I guess there may be cases where two separate command are actually helpful...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants