Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trip Recording: initial form is shown multiple times if the Rec button is pressed more than once #17910

Closed
Max1234-Ita opened this issue Aug 13, 2023 · 2 comments · Fixed by #18028
Assignees
Labels
Milestone

Comments

@Max1234-Ita
Copy link
Contributor

Max1234-Ita commented Aug 13, 2023

Description

I just noticed that if I tap several times the Rec button on the map display, the Trip Recording initial form is displayed the same number of times.

Since I guess only one position log can be recorded at the same time, I think a check should be present to prevent initiation of multiple instances.

How to reproduce

  1. Launch OsmAnd

  2. Make sure the Rec button is displayed in the right panel.

  3. Quickly tap the Rec button several times (i.e., 3).

  4. Notice the recording configuration form is displayed the same number of times.

  5. Tap the 'x' (Cancel) button to close the tool.

  6. Notice that the Recording form is closed but another instance is present below it.

Actual result

Multiple instances of the Trip Recording configuration form are started at once.

Expected result

User should be able to initiate only one instance of the recording tool at a time.
A check should be present to verify if the recording configuration form is already visible: if so, it should not be displayed again before the user closes it.

Environment
OsmAnd Version: Osmand Plus v.4.5.10
Android/iOS version: Android 11
Device model: Samsung Galaxy A50 (SM-A505 FN)

@Max1234-Ita Max1234-Ita changed the title Trip Recording: initial form is shown multiple times of the Rec button is pressed more than once Trip Recording: initial form is shown multiple times if the Rec button is pressed more than once Aug 13, 2023
@DmitryAlexei
Copy link
Contributor

OsmAnd~ 4.6.0#611m, released: 2023-08-15
When quickly tapping on the rec button, it is possible sometimes to open two windows of trip recording initial dialog (not easy reproducible in everyday conditions).

Screen_Recording_20230815_141126_OsmAnd.mp4

@Max1234-Ita
Copy link
Contributor Author

If the user has a non-flagship device, with limited copy resources, it's quite easy to reproduce 🙂

@vshcherb vshcherb added this to the 4.7-android milestone Aug 15, 2023
@0xRe1nk0 0xRe1nk0 linked a pull request Aug 28, 2023 that will close this issue
@vshcherb vshcherb modified the milestones: 4.7-android, 4.6-android Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants