Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter GPS speed fluctuations near 0 #19230

Closed
pl71 opened this issue Mar 2, 2024 · 15 comments
Closed

Filter GPS speed fluctuations near 0 #19230

pl71 opened this issue Mar 2, 2024 · 15 comments
Assignees
Labels
Milestone

Comments

@pl71
Copy link
Contributor

pl71 commented Mar 2, 2024

Describe the idea (required)

  1. Assume vehicle is stopped if GPS speed is less than 2 km/h
  2. Assume vehicle is oriented properly (as per route calculated) in the beggining.

Tell us about the expected behaviour (required)

Do not rotate car icon when speed is too low.

Tell us about alternatives you've considered (required)

Icon should stay fixed. A car can't rotate too fast.

Context (optional)

Kalman filter is ON.
No response

@pl71 pl71 changed the title Filter speed fluctuations neat 0 Filter GPS speed fluctuations near 0 Mar 3, 2024
@sonora
Copy link
Member

sonora commented Mar 3, 2024

I believe our default behavior is acually like you say it should be. Perhaps check the settings of you car profile, 'Kalman filter' should be on, and 'Use magnetic sensor' off.

@yuriiurshuliak
Copy link

The bug has been reproduced. I attempted to reset the driver profile settings and reproduce the issue with standard settings, enabling the 'Kalman filter' and disabling 'Use magnetic sensor.'

In the first video, I attempted to initiate car navigation while moving on foot. In the second video, I simulated navigation at fixed speeds of 3 miles. The issue persists in both scenarios.

OsmAnd~ 4.7.0#1740m, released: 2024-03-04

video_2024-03-04_18-37-11.mp4
video_2024-03-04_18-37-12.mp4

@pl71
Copy link
Contributor Author

pl71 commented Mar 4, 2024

I believe our default behavior is acually like you say it should be. Perhaps check the settings of you car profile, 'Kalman filter' should be on, and 'Use magnetic sensor' off.

Yes, my settings are exactly the same. I don't know what Kalman filter exactly does, suppose it suppresses some GPS glitches. In fact it should be more aggressive at low speeds.

@vshcherb vshcherb added this to the 4.7-android milestone Mar 16, 2024
@Chumva
Copy link
Member

Chumva commented Mar 26, 2024

This should be fixed here if snap to road is enabled & we follow route

@Chumva Chumva closed this as completed Mar 26, 2024
@pl71
Copy link
Contributor Author

pl71 commented Mar 26, 2024

Where is snap to road?

@dmpr0
Copy link
Contributor

dmpr0 commented Mar 27, 2024

Where is snap to road?

Menu – Settings – Select profile – Navigation settings – Map during navigation

@pl71
Copy link
Contributor Author

pl71 commented Mar 27, 2024

Yes, it is ON. I hope to be fixed at the next release. Otherwise, it is not common for a car to rotate so fast.

@limex
Copy link

limex commented Apr 2, 2024

This should be fixed here if snap to road is enabled & we follow route

I'm confused. This fix is also relevant for non-driving profiles. Like hiking. Currently when standing, often there is still movement "detected". Leading to not showing the viewing direction, because the movement direction arrow is shown instead.
But: There are often no roads we are walking at, we don't want to be "fixed" to the track. We want to know when we are off-track.
This is a major pain for hikers since 4 years. I trust that this fixes our our issues.

@vshcherb
Copy link
Member

vshcherb commented Apr 2, 2024

This is a major pain for hikers since 4 years.

Appellation to something going long enough without clear decscription won't work cause of multiple and emotions don't help to make right decisions.

Movement direction is detected by GPS signal / driver so it depends on device / operating system. Viewing direction provides even worse results when movement detected
So I think primary issue is wrong movement detection and fix is unknown yet.

@pl71
Copy link
Contributor Author

pl71 commented Apr 2, 2024

GPS fluctuations are not sometnig new. They exists for all positioning systems as well. Up to the software is to filter them appropriately. Car profile assume you are in an average car from mass production, not in Ferrari. Accelaration should be within some limits. As well as rotating speed. At low speeds (for example < 5km/h) you can't rotate too fast.

@limex
Copy link

limex commented Apr 3, 2024

GPS fluctuations are not sometnig new. They exists for all positioning systems as well. Up to the software is to filter them appropriately. Car profile assume you are in an average car from mass production, not in Ferrari. Accelaration should be within some limits. As well as rotating speed. At low speeds (for example < 5km/h) you can't rotate too fast.

You didn't understand my concerns. Let me make it clear:
Don't bundle the new fix to the setting "snap to road"! Please!

Because "snap to road" is bullshit when you are out in the wild with the profile Hiking. You dont want to be snaped to road. You want to know when you are off track!

@limex
Copy link

limex commented Apr 3, 2024

This is a major pain for hikers since 4 years.

Appellation to something going long enough without clear decscription won't work cause of multiple and emotions don't help to make right decisions.

Movement direction is detected by GPS signal / driver so it depends on device / operating system. Viewing direction provides even worse results when movement detected So I think primary issue is wrong movement detection and fix is unknown yet.

  1. Thanks for taking care of this.
  2. Sorry for me being emotional but ...
  3. ... since 4 years Hikers wrote numerous tickets, comments to get heard by the motorist's fraction of the OSMand Users/Developers.
  4. Don't get me started on the "depends on device / operating system." statement. We had that over and over. Everytime we convinced one "motorist" he/she disappeared and another one showed up. #groundhoundday

Anyway. Thanks again that you are moving things forward.

And: I hope this fix standalone. Which means: It is not enabled with the "snap to road" setting. Please confirm.

@vshcherb
Copy link
Member

vshcherb commented Apr 6, 2024

@limex I didn't understand much, only your statement that I didn't understand. Nothing is going to change if keep your messages short and precise.

Please describe what's the issue you occur, probably better start a new thread. Please focus on your issue, what do you want to achieve, what's your situation. Don't focus on any specific solution cause it might not work for other scenarios

@limex
Copy link

limex commented Apr 6, 2024

@vshcherb
This explains the issue in detail: osmandapp/OsmAnd-iOS#3553

But: Let's start from here:
Question: will the new fix "Filter GPS speed fluctuations" also be enabled, if the "snap to road" is disabled?
If YES: You are our hero, we will praise you for fixing an 4 year issue.
IF NO: We need to talk

@vshcherb
Copy link
Member

vshcherb commented Apr 6, 2024

Ok, I will stop conversation and reply in osmandapp/OsmAnd-iOS#3553 (comment) cause it's not you a topic starter. No description - no bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants