-
-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Commit history question #19901
Comments
Comment is visible now in master
|
So what had happened, can anybody explain? |
nothing, have no idea. Commit was merged from 4.7? |
From what I see, all relevant commits were directly to master. I had observed something like this on 2 or 3 occasions lately, and was really baffled. This example was the most straightforward to illustrate it with... |
I haven't checked this particular example (I'm on a mobile phone right now) but git allows to perform changes within a merge commit which you won't see when looking at the individual commits. You have to look at the diff of the merge commit instead. This is a really strange and scary behavior of git in my opinion. |
It's in master branch - git log -1000 | grep -A 5 -B 5 f1aa507
I don't see anything strange. it was merged from r4.7 to master |
Perhaps a UI peculiarity I fail to understand or glitch on github.com then. Because as you can see in the second screenshot I had provided above, the comments in code line t44 should have been present but are not reflected. |
I am currently a bit baffled why this commit to the master branch f1aa507
is not reflected in this commit's history 290c953, which leads to the comment added by @ivanPyrohivskyi not being visible in our master branch now?
The text was updated successfully, but these errors were encountered: