Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing the standard appearance of a Track folder is buggy... #20125

Closed
Rowin63 opened this issue Jun 18, 2024 · 9 comments
Closed

Editing the standard appearance of a Track folder is buggy... #20125

Rowin63 opened this issue Jun 18, 2024 · 9 comments

Comments

@Rowin63
Copy link

Rowin63 commented Jun 18, 2024

Description

) three tracks in a folder, named A, B and C.
) in "my places" I set the folders "standard appearance" to yellow and apply (at this point no question "existing or new" is asked). Apply.
) tracks A, B and C are yellow now.
) move one more track, named D, into this folder
) A, B and C are yellow, D is green.
) set the folders "standard appearance" again to yellow, now Iḿ asked "existing or new?" and select "new"
) tracks A, B, C and D are yellow. Fine!
) add another track named E to this folder.
) track E is green, but at this point also track D has switched back to green again!
) you can continue this game, and every time only the initial tracks A, B and C keep their color when adding a track. All the others are always set back to their previous color, when adding a new track.

Steps to reproduce

See above.

Actual result

Switching the previously added tracks color back to their origin when adding a new track.

Expected result

Keep the color as defined.

Your Environment (required)

4.8.0#2515

@Rowin63
Copy link
Author

Rowin63 commented Jun 18, 2024

The same issue in the last playstore release +4.7.17 but a little different: no matter if you apply to "existing" or "new" tracks, after a restart of the app all changes are gone...

@dmpr0 dmpr0 changed the title Editing the standard appearance of a folder is buggy... Editing the standard appearance of a Track folder is buggy... Jun 18, 2024
@yuriiurshuliak
Copy link

The bug was partially reproduced. I created a folder, added three tracks, and set the "standard appearance" to yellow. Then, I added another track with a blue appearance. Following your instructions, I changed the "standard appearance" back to yellow and selected the "Apply only to new" option. However, the blue track's color did not change to yellow.

Additionally, when I added another blue track, its color also did not change to yellow, despite the "standard appearance" being set to yellow and the "Apply only to new" option being selected.

OsmAnd~ 4.8.0#2533m, released: 2024-06-19

video_2024-06-19_11-54-45.mp4

@Rowin63
Copy link
Author

Rowin63 commented Jun 19, 2024

I couldn't reproduce today as it was yesterday, but the behavior is different every few uses...

Like:
) In a YELLOW folder there are three tracks.
) I move one track from the GREEN folder to the YELLOW one, and there it still is GREEN.
) set standard appearance of the YELLOW folder again to YELLOW and apply to "existing tracks"
) all four tracks are YELLOW now
) move one more GREEN track into the YELLOW folder
) content now is 3 Yellow and 1 GREEN
) but setting standard appearance again to YELLOW is not possible now, though there is a GREEN track in the YELLOW folder. But the color menu still shows YELLOW as set and I can't apply it again.

I have to go via another color, apply it and then can go back to yellow again...

Using today's 4.8.0#2534

@Rowin63
Copy link
Author

Rowin63 commented Jun 19, 2024

Yes, "apply to new" does not do anything to new tracks moved into a folder.
They remain as they have been before in the previous folder.

@Rowin63
Copy link
Author

Rowin63 commented Jun 19, 2024

One question:
setting a folders appearance AFTER adding tracks to it: are this NEW or EXISTING tracks?
Because they are ALWAYS changed, no matter what you select.
(+4.7.17)

@Rowin63
Copy link
Author

Rowin63 commented Jun 19, 2024

Anyway, applying the standard appearance of a TRACK-FOLDER should automatically apply to all added tracks. Why should tracks I moved to a folder I defined as YELLOW be displayed in any other colour? Why to set the folders appearance as standard if the tracks don't follow this setting (no use for "existing" or "new"?

@vshcherb
Copy link
Member

Default appearance only applied for tracks which don't have track color selected so it works as expected, yo u need to change track appearance of selected tracks

@yuriiurshuliak
Copy link

As I understand it, this is expected behavior. The "Apply only to new" option affects only tracks that have not been assigned a specific color, meaning those with the default appearance. If you've set the default appearance for a folder and chosen "Apply only to new,"it won't affect tracks that already have a custom appearance set.

OsmAnd~ 4.8.0#2568m, released: 2024-06-24

video_2024-06-24_12-14-20.mp4

@Rowin63
Copy link
Author

Rowin63 commented Jun 24, 2024

Yes of course, it depends on how you define it.
"new" to me is "new in this folder", no matter if edited previously or not. And only with this option it would be possible, to easily set the standard appearance by FOLDER (and thereby all its contained tracks). So "my" new is different from "your" new.

But: choosing "existig" does not follow this/your rule, "existing" means "all existing", no matter if previously edited or not.
It´s just ALL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants