Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpeningHours: Display NextChange #473

Closed
ypid opened this issue Jul 23, 2013 · 7 comments
Closed

OpeningHours: Display NextChange #473

ypid opened this issue Jul 23, 2013 · 7 comments

Comments

@ypid
Copy link
Contributor

ypid commented Jul 23, 2013

Hi

I have a feature request.
It would be nice to see (without calculating yourself it based on the opening_hours string) how long the shown facilities will be open or to be more specific when the state will change.

Could someone who is a bit more into the Java implementation write this down. I found a reference implementation of this in JavaScript: https://github.com/AMDmi3/opening_hours.js

As said I would prefer to see this in the overview (the view with the colored arrows).

@ypid
Copy link
Contributor Author

ypid commented Aug 7, 2013

What do you say about using one of the JS implementations in OsmAnd instead of maintain the same thing in different languages? The implementation from netzwolf seems to be the most feature complete one.
http://stackoverflow.com/questions/8374016/how-to-execute-javascript-on-android

@vshcherb
Copy link
Member

vshcherb commented Aug 7, 2013

Overkill

@vshcherb vshcherb closed this as completed Aug 7, 2013
@ypid
Copy link
Contributor Author

ypid commented Aug 8, 2013

Well I agree it is a lot of abstraction, but this is not performance relevant and it would make this a lot easier. I would prefer this hack over a not really feature complete implementation. Maybe in the future there will be a good and feature complete Java implementation but at this time it seems not to be the case.
Does the closed issue mean that you are not interested at all in this feature or do you just don’t like the way I suggested to implement it?
One example of this: http://oeffnungszeiten.ulmapi.de/

@vshcherb
Copy link
Member

vshcherb commented Aug 8, 2013

It is overkill for Android application, not for web :)

@vshcherb
Copy link
Member

vshcherb commented Aug 8, 2013

No implementation could be fully complete in OSM.

@ypid
Copy link
Contributor Author

ypid commented Aug 9, 2013

True, but we have a specification. And it would be a good start supporting as much as possible of it don’t you think?
I still would like this feature.

@ypid
Copy link
Contributor Author

ypid commented Dec 4, 2013

JOSM has integrated https://github.com/ypid/opening_hours.js some time age. Maybe it is worth doing the same in OsmAnd as already proposed by me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants