Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support dusk and dawn in opening hours #8375

Open
Discostu36 opened this issue Feb 2, 2020 · 6 comments
Open

Support dusk and dawn in opening hours #8375

Discostu36 opened this issue Feb 2, 2020 · 6 comments
Labels
Nice to Have Should be fixed but there is no priority or no possibility to fix it within current horizon planning

Comments

@Discostu36
Copy link
Contributor

Osmand 3.5.5
Android 9
Samsung Galaxy A7 (2018)
Map: Schleswig-Holstein, Germany, January 2020
Osmand Live from 2020-02-02 13:11 MEST
Screenshot_20200202-131256_OsmAnd
@pebogufi
Copy link

pebogufi commented Feb 2, 2020

Missig comma before dusk ?

@Discostu36
Copy link
Contributor Author

Semicolon is there, only not shown in Osmand

https://www.openstreetmap.org/way/769025123#map=17/54.32453/10.12535

@Discostu36
Copy link
Contributor Author

Screenshot_20200202-153741_OsmAnd

https://www.openstreetmap.org/node/4471598201 Seems to be a general problem with dusk and dawn

@Discostu36 Discostu36 changed the title POI shown as closed when open Support dusk and dawn in opening hours Feb 2, 2020
@vshcherb vshcherb added the Nice to Have Should be fixed but there is no priority or no possibility to fix it within current horizon planning label Feb 3, 2020
@vshcherb
Copy link
Member

vshcherb commented Feb 3, 2020

I think now only sunrise/sunset is supported

@nyanmeister
Copy link

Here's some documentation for a start on how to implement calculating dusk and dawn by the coordinates of the PoI or Area.
https://gml.noaa.gov/grad/solcalc/calcdetails.html
https://github.com/litanx/Dusk_Dawn_Calculation

@vshcherb Does putting "sunset" already do the procedure of calculating the location's specific sunset? If so I'll just use that instead on my features.

@vshcherb
Copy link
Member

@vshcherb Does putting "sunset" already do the procedure of calculating the location's specific sunset? If so I'll just use that instead on my features.

Sunset is hardcoded and doesn't calculate it on spot right now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Nice to Have Should be fixed but there is no priority or no possibility to fix it within current horizon planning
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@vshcherb @pebogufi @nyanmeister @Discostu36