Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] String translation looks bad on the interface. #5615

Closed
franco999 opened this issue Jun 25, 2018 · 6 comments
Closed

[Suggestion] String translation looks bad on the interface. #5615

franco999 opened this issue Jun 25, 2018 · 6 comments
Assignees

Comments

@franco999
Copy link
Contributor

In several languages, the translation of the phrase "Add GPX file" is very long (along with the phrase "ok" and "cancel") and looks bad on the interface. Instead of "Add GPX", it could be displayed correctly on the interface.
My question is, is it possible to change the original string or does it depend on each translation? (https://github.com/osmandapp/Osmand/blob/master/OsmAnd/res/values/strings.xml#L511)

For example:
Spanish: Bad. (add GPX file)
es
Spanish: Good. (add GPX)
es2
German:
de
French:
fr
Italian:
it

@sonora
Copy link
Member

sonora commented Jun 26, 2018

I have changed the string to "Add more…", let's see if that fixes the issue. thx-

@sonora sonora closed this as completed Jun 26, 2018
@sonora sonora self-assigned this Jun 26, 2018
@franco999
Copy link
Contributor Author

I don't know well in the other languages but in Spanish, "Add GPX" (Añadir GPX) is shorter than "Add more..." (Añadir más...). Besides, with the second sentence, it also looks bad. I had to revert it to "Add GPX".

I think now, it's up to each translator.

@IgorEliezer
Copy link
Contributor

IgorEliezer commented Jun 28, 2018

I had the same problem with OsmAnd Live → Live Updates, where you find update_now, cancel and ok at the bottom.

If update_now button was anything longer than 11 characters all the 3 buttons kept breaking lines and going off screen. I ended up dropping the "now" part to make the translation shorter. I'd think buttons could "cut off" long strings to avoid going off screen or breaking lines, but I'm not sure if it's a better approach.

@dmpr0
Copy link
Contributor

dmpr0 commented Jun 28, 2018

It is the default behavior of dialogs with 2 or 3 buttons. We support all languages. Our main goal it good understanding of what that button does, how it looks, in one line or in a column not so important.

@comradekingu
Copy link
Contributor

comradekingu commented Jul 3, 2018

"Add more…" seems imprecise.
"+GPX" is nice and short.
In any event the comment should state max-length.

@ldmpub
Copy link
Contributor

ldmpub commented Jul 3, 2018

Hi,

I agree with @comradekingu: to make sense the label "GPX" should be part of the sentence in all languages ... Maybe we should think to change layout for labels / buttons in this particular dialog box.

Other way to handle this issue: Weblate should warn translators of the max string length supported for this string (but it maybe hard to determine it because of device used).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants