Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maxspeed:conditional: snow/wet -> false #7652

Closed
mpele opened this issue Oct 8, 2019 · 4 comments
Closed

maxspeed:conditional: snow/wet -> false #7652

mpele opened this issue Oct 8, 2019 · 4 comments
Assignees
@MadWasp79 @max-klaus
Labels
Nice to Have Should be fixed but there is no priority or no possibility to fix it within current horizon planning
Milestone
3.8-backend

Comments

@mpele
Copy link

mpele commented Oct 8, 2019

I have faced the similar behavior like it was described in #5198
On motorway https://www.openstreetmap.org/way/681082296#map=17/44.61339/20.64163 OsmAnd recognize max speed as 60 (instead of 130) and the routing is, as expected, not reasonable.
@mpele
Copy link
Author

mpele commented Oct 8, 2019

I have to mention that if in the setting for routing is turned off "Consider temporary limitations" it work correctly.

@vshcherb vshcherb added the Nice to Have Should be fixed but there is no priority or no possibility to fix it within current horizon planning label Oct 9, 2019
@mpele
Copy link
Author

mpele commented Oct 14, 2019

@vshcherb I think this should be treated as bug, not a "Nice to Have".
It looks that there are two bugs:

  1. The conditional speed should not be considered as temporary limitation
  2. The conditional speed is accepted even the condition could not be confirmed

@scaidermern
Copy link
Contributor

scaidermern commented Feb 5, 2020 •
edited
Loading

I can confirm. This is a regression of #5198. Conditional maxspeed values like maxspeed:conditional=80 @ wet aren't interpreted correctly. The condition always evaluates to true.

Example from geo:51.454063,12.213502?z=14 to geo:51.460953,12.216457?z=14
OsmAnd displays a speed limit of 100 but way 215848071 is tagged as maxspeed=none + maxspeed:conditional=100 @ wet.

photo_2020-02-05_10-17-55

This is not a "nice to have", this is the same bug as from #5198 again. Maybe add a unit test?

@vshcherb vshcherb added this to the Future milestone milestone Feb 5, 2020
@vshcherb vshcherb changed the title maxspeed:conditional and snow maxspeed:conditional: snow/wet -> false Feb 5, 2020
@vshcherb vshcherb modified the milestones: Future milestone, 3.8, 3.8-backend Jun 9, 2020
@vshcherb vshcherb assigned crimean and max-klaus and unassigned crimean Jun 19, 2020
@max-klaus
Copy link
Contributor

Fixed by osmandapp/OsmAnd-core@6d83d8b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MadWasp79 MadWasp79

@max-klaus max-klaus

Labels
Nice to Have Should be fixed but there is no priority or no possibility to fix it within current horizon planning
Projects
None yet
Milestone
3.8-backend
Development

No branches or pull requests
6 participants
@scaidermern @vshcherb @crimean @mpele @MadWasp79 @max-klaus