use NetworkUtils.getHttpURLConnection for all URLConnections #1081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This keeps the code consistent, provides a single common method for setting up URLConnections, and allows the proxy support to work on all network connections. NetworkUtils.getHttpURLConnection() provides a common method for creating HttpUrlConnection instances from URLs. That's where the proxy config happens. If you can think of a better way to add proxy support, I'm all ears. This is the best that we've found in our proxy work at Guardian Project. this is a follow up on osmandapp#1043
vshcherb
added a commit
that referenced
this pull request
Feb 20, 2015
use NetworkUtils.getHttpURLConnection for all URLConnections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This keeps the code consistent, provides a single common method for setting
up URLConnections, and allows the proxy support to work on all network
connections.
NetworkUtils.getHttpURLConnection() provides a common method for creating
HttpUrlConnection instances from URLs. That's where the proxy config
happens. If you can think of a better way to add proxy support, I'm all
ears. This is the best that we've found in our proxy work at Guardian
Project.
this is a follow up on #1043