Waterway checks (does not end in sink, crosses without intersection, closed waterway)

[tsmock]

Description
This is largely a migration of Osmose 1070/1220 (waterway overlaps, waterway intersecting waterway without junction, unconnected waterway, and closed waterway).

Requirements

• Is an Edge or a Line (logic should use LineItem where ever possible), since waterways may become an Edge in the future (specifically navigable waterways, so rivers, not small streams), and has valid waterway water values.

Use Cases
This section summarizes the various use cases for this check and provides potential enhancement suggestions if needed. The uses cases should act as a test in a way, such that when the analysis/enhancement is completed, these types of use cases should be found or eliminated.

For each use case, please add a screenshot of the feature & openstreetmap.org link (or other sources). If necessary, edit the screenshot to better illustrate the use case.

Example:

Case 1: Sinkhole area (Colorado, US)

• This should not be flagged, since sinkholes act as an exit for waterways.
• https://www.openstreetmap.org/way/538940188
  

Case 2: Sinkhole point (Utah, US)

• This should not be flagged, since sinkholes act as an exit for waterways. Note that this is apparently not a sinkhole (see the description tag, but that is a separate issue).
• https://www.openstreetmap.org/node/7704038746
  

Case 3: Closed waterway (Colorado, US)

• This should be flagged. It looks like it should be natural=water + water=canal instead of waterway=ditch (it looks more like a canal than a ditch).
• https://www.openstreetmap.org/way/46115766
  

Case 4: Waterway ending in an ocean (Florida, US)

• This should not be flagged, since water ending inside an ocean has a sink
• https://www.openstreetmap.org/way/556331627 (Coastline)
• https://www.openstreetmap.org/way/163762083#map=15/29.2075/-89.2731 (River -- waterway)
  

Case 5: Waterway crossing waterway (Colorado, US)

• This should be flagged, if the layer tags are the same. This example has a duplicate node at the crossing location as well, but that should not be necessary.
• https://www.openstreetmap.org/way/40979547
• https://www.openstreetmap.org/way/41180223
• https://www.openstreetmap.org/way/40950607
• https://www.openstreetmap.org/way/41068197
  

• Case 6: Deadend waterway (Colorado, US)*

• This should be flagged. Waterways must have a sink. Multiple waterways may deadend into each other (so converge into a dead end). For the purposes of a navigable network, a waterway ending on a water area is considered a dead end (see linked way).
• https://www.openstreetmap.org/way/41207956
  

• Case 7: Tidal Channel (Belize)*

• This should not be flagged as missing a sink. It may be flagged for other reasons, such as overlapping/intersecting with another waterway.
• https://www.openstreetmap.org/way/796347512
  

Further investigation
A sample region needs to be tested to see what the approximate false positive rate is. Belize had 311 flags for the standard waterway checks.

Supported regions
All countries

What's not supported (optional):
This check is not currently doing area checks (so riverbank without river, crossing waterway areas, since the crossing waterway areas currently has a bug whereby two areas sharing a point is considered an intersection).

References

• OSM Wiki Waterways: https://wiki.openstreetmap.org/wiki/Waterways
• OSM Wiki Riverbank: https://wiki.openstreetmap.org/wiki/Tag:waterway%3Driverbank
• Waterway way checks: https://github.com/taylorsmock/atlas-checks/tree/feature/waterway-check