Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table items #90

Open
felskia opened this issue Aug 14, 2017 · 5 comments
Open

Table items #90

felskia opened this issue Aug 14, 2017 · 5 comments
Assignees

Comments

@felskia
Copy link
Collaborator

felskia commented Aug 14, 2017

@dereklieu I am wondering where the table columns are coming from. My thought of ones that would be good would be the following:

  • Name of item (ex. Ballard Elementary School)
  • Device or person who submitted
  • How complete the observation is
  • The time that it came in
  • What survey it came from

Let me know what you think here.

@dereklieu
Copy link
Collaborator

This sounds good. I'm basically just spitting out all the properties on every observation right now, but that's not very usable.

One thing, I'm not actually sure we can tell how complete an observation is. We could maybe have a metric for how complete a survey is, but that seems out of scope.

@felskia
Copy link
Collaborator Author

felskia commented Aug 14, 2017

We're supposed to be doing this on the observation. At least tracking how complete it is in the app. Maybe this is something to ask @sethvincent about?

@sethvincent
Copy link
Contributor

sethvincent commented Aug 14, 2017

I think completeness is calculated like this:

  • get an observation
  • get the related survey by its id
  • get the fields associated with that survey
  • figure out which of the total fields have been completed based on the properties on the observation
  • turn that into a percentage

My plan for the mobile app was to calculate it for any view that needs it as part of the map function that turns objects into ui components, rather than set a property on the observation.

It's possible we could set the completeness percentage as a property to simplify things.

@dereklieu
Copy link
Collaborator

Ah I see.

I'm actually fine not attaching it as a property, I feel that has the potential to complicate it more. @sethvincent have you already written the code to calculate completion? If so maybe I could modify what you've already done.

@sethvincent
Copy link
Contributor

Cool. I think I agree about not making it a property. I haven't written that calculation function yet. Was expecting to get that bit done later this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants