Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Research needed for: shop/shoes|Office #1614

Closed
bhousel opened this issue Oct 17, 2018 · 4 comments
Closed

Research needed for: shop/shoes|Office #1614

bhousel opened this issue Oct 17, 2018 · 4 comments
Labels
good first issue Best for first-time contributors. No experience necessary!

Comments

@bhousel
Copy link
Member

bhousel commented Oct 17, 2018

🤔 We need help deciding what to do with "shop/shoes|Office"

👉 Read the CONTRIBUTING.md guide for more info, and feel free to ask questions on this issue!

What's needed

First, do some research on shop/shoes|Office by searching Google and Wikipedia.

If it is an actual brand:

  • Edit config/canonical.json:
    • Find the entry for shop/shoes|Office
    • Add tags for brand:wikidata and brand:wikipedia
    • Optionally add "countryCodes" or other tags
  • npm run build
  • Commit your changes and submit a pull request

If it is not an actual brand:

  • Edit config/filters.json to add an expression that discards it
  • Edit config/canonical.json to remove the entry for shop/shoes|Office
  • npm run build
  • Commit your changes and submit a pull request

If the situation is complicated:

  • Leave a comment on this issue with what you find

✨ Thanks!

This is an autogenerated ticket

@bhousel bhousel added good first issue Best for first-time contributors. No experience necessary! Hacktoberfest labels Oct 17, 2018
@kymckay
Copy link
Collaborator

kymckay commented Dec 29, 2018

Likely this: https://en.wikipedia.org/wiki/Office_Holdings
Their website: https://www.office.co.uk/view/content/about-us-page

I guess this wikipedia page doesn't apply to the brand as it's not specific to the chain, but to the company which operates them? 🤔

@lakedistrictOSM
Copy link

The infobox on that wiki page literally says that it's a shoe shop, so I'd say that it's good enough to use. It can go in the operator wiki tags at the very least...

@Adamant36
Copy link
Collaborator

Looks perfectly fine for brand wikipedia tag. The name is "Office" and the article says how many stores they have. It specifically says the products is shoes also. So I don't see why not.

The operator Wikipedia tag could be Truworths. It says in the article that its their parent company.

@Adamant36
Copy link
Collaborator

Adamant36 commented Mar 6, 2019

Added in #2384

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Best for first-time contributors. No experience necessary!
Projects
None yet
Development

No branches or pull requests

4 participants