Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Research needed for: amenity/bank|Kasa Stefczyka #272

Closed
bhousel opened this issue Oct 16, 2018 · 6 comments
Closed

Research needed for: amenity/bank|Kasa Stefczyka #272

bhousel opened this issue Oct 16, 2018 · 6 comments
Labels
good first issue Best for first-time contributors. No experience necessary! needs wikidata It is necessary to create a wikidata entry

Comments

@bhousel
Copy link
Member

bhousel commented Oct 16, 2018

🤔 We need help deciding what to do with "amenity/bank|Kasa Stefczyka"

👉 Read the CONTRIBUTING.md guide for more info, and feel free to ask questions on this issue!

What's needed

First, do some research on amenity/bank|Kasa Stefczyka by searching Google and Wikipedia.

If it is an actual brand:

  • Edit config/canonical.json:
    • Find the entry for amenity/bank|Kasa Stefczyka
    • Add tags for brand:wikidata and brand:wikipedia
    • Optionally add "countryCodes" or other tags
  • npm run build
  • Commit your changes and submit a pull request

If it is not an actual brand:

  • Edit config/filters.json to add an expression that discards it
  • Edit config/canonical.json to remove the entry for amenity/bank|Kasa Stefczyka
  • npm run build
  • Commit your changes and submit a pull request

If the situation is complicated:

  • Leave a comment on this issue with what you find

✨ Thanks!

This is an autogenerated ticket

@bhousel bhousel added good first issue Best for first-time contributors. No experience necessary! Hacktoberfest labels Oct 16, 2018
@matkoniecz
Copy link
Contributor

Add tags for brand:wikidata and brand:wikipedia

It has no own wikipedia entry. Brand is based on https://pl.wikipedia.org/wiki/Kasa_Stefczyka - but article is not about the current company.

@matkoniecz
Copy link
Contributor

https://pl.wikipedia.org/wiki/Sp%C3%B3%C5%82dzielcza_kasa_oszcz%C4%99dno%C5%9Bciowo-kredytowa describes this type of company, not just this one brand.

@bhousel
Copy link
Member Author

bhousel commented Oct 16, 2018

I don't know, @matkoniecz - use your best judgement.
If it's not really a brand, we can just discard it from the index.

@matkoniecz matkoniecz reopened this Oct 22, 2018
@matkoniecz matkoniecz added the needs wikidata It is necessary to create a wikidata entry label Oct 22, 2018
@matkoniecz
Copy link
Contributor

It is a brand but currently there is no wikidata or wikipedia page for it. Is it OK to just create nearly empty Wikidata entry for that brand?

@bhousel
Copy link
Member Author

bhousel commented Oct 22, 2018

It is a brand but currently there is no wikidata or wikipedia page for it. Is it OK to just create nearly empty Wikidata entry for that brand?

Yes I think so 👍

@matkoniecz
Copy link
Contributor

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Best for first-time contributors. No experience necessary! needs wikidata It is necessary to create a wikidata entry
Projects
None yet
Development

No branches or pull requests

2 participants